Validate size parameters in weight Read methods. - #268
Merged
Conversation
copybara-service
Bot
force-pushed
the
copybara/954563883
branch
2 times, most recently
from
July 27, 2026 14:09
e30c8b2 to
3ff4bee
Compare
In `SetWeight`, `StringWeight`, and `UnionWeight`, reading deserialized weight sizes from input streams previously lacked bounds validation and stream failure checking. Large or negative size inputs could lead to integer overflows during buffer calculation or undefined behavior on read failure. PiperOrigin-RevId: 954617954
copybara-service
Bot
force-pushed
the
copybara/954563883
branch
from
July 27, 2026 14:30
3ff4bee to
cb1b8ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate size parameters in weight Read methods.
In
SetWeight,StringWeight, andUnionWeight, reading deserialized weight sizes from input streams previously lacked bounds validation and stream failure checking. Large or negative size inputs could lead to integer overflows during buffer calculation or undefined behavior on read failure.