Fix unvalidated arc count and integer overflow in VectorFst deserialization. - #265
Merged
Conversation
copybara-service
Bot
force-pushed
the
copybara/954551590
branch
2 times, most recently
from
July 27, 2026 13:01
bbdf598 to
bcd804d
Compare
…zation. In `VectorFst::Read`, validate that the serialized arc count (`narcs`) is non-negative and does not cause integer overflow when calculating required memory before reserving arc storage. Also add unit tests to verifying rejection of negative and oversized arc counts. **Note**: This is a partial fix that addresses negative arc counts and integer overflows. Large arc counts that do not trigger 64-bit integer overflow (e.g., 1 billion arcs, which would attempt to allocate ~24 GB of RAM) currently remain unvalidated without stream bounding or maximum allocation limits. PiperOrigin-RevId: 954590203
copybara-service
Bot
force-pushed
the
copybara/954551590
branch
from
July 27, 2026 13:21
bcd804d to
1c4ccf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unvalidated arc count and integer overflow in VectorFst deserialization.
In
VectorFst::Read, validate that the serialized arc count (narcs) is non-negative and does not cause integer overflow when calculating required memory before reserving arc storage. Also add unit tests to verifying rejection of negative and oversized arc counts.Note: This is a partial fix that addresses negative arc counts and integer overflows. Large arc counts that do not trigger 64-bit integer overflow (e.g., 1 billion arcs, which would attempt to allocate ~24 GB of RAM) currently remain unvalidated without stream bounding or maximum allocation limits.