Followup PR: Implement IMAS output core_sources mapping #2231
Open
MateoBell wants to merge 4 commits into
Open
Followup PR: Implement IMAS output core_sources mapping #2231MateoBell wants to merge 4 commits into
MateoBell wants to merge 4 commits into
Conversation
MateoBell
force-pushed
the
pr4-core-sources-tests
branch
3 times, most recently
from
June 19, 2026 12:49
9edeaab to
fd7cb81
Compare
MateoBell
force-pushed
the
pr5-generic-sources-mapping
branch
from
June 19, 2026 13:05
e4c26b6 to
93e00f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition to also map the TORAX generic sources to IMAS. Using the custom identifiers from https://imas-data-dictionary.readthedocs.io/en/latest/generated/identifier/core_source_identifier.html#identifier-core_sources-core_source_identifier.xml, and adds description to be more explicit.