(PR 2/2) Add main_ions contribution to output core_profiles mapping#2227
Open
MateoBell wants to merge 1 commit into
Open
(PR 2/2) Add main_ions contribution to output core_profiles mapping#2227MateoBell wants to merge 1 commit into
MateoBell wants to merge 1 commit into
Conversation
Nush395
reviewed
Jul 17, 2026
| cp_state.pressure_thermal_e.cell_plus_boundaries() | ||
| ) | ||
| ids.profiles_1d[i].electrons.pressure_thermal = pressure_thermal_e | ||
| ids.profiles_1d[i].pressure_ion_total = pressure_thermal_i |
Collaborator
There was a problem hiding this comment.
should this also include pressure_fast_i?
| # Retrieve fast ion contribution to main ion density and pressure. | ||
| n_species_fast = np.zeros_like(n_species) | ||
| ion_pressure_fast = np.zeros_like(n_species) | ||
| for fast_ion in fast_ions: |
Collaborator
There was a problem hiding this comment.
this loop is duplicated below I believe, can it be extracted into a separate helper?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits #1827 to add fast_ions contributions separately.
Include main_ions to compute total ion density and pressure and the individual ions pressure and densities.