fix: use left-biased 3-point stencil for face gradients on non-uniform grids#2202
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix: use left-biased 3-point stencil for face gradients on non-uniform grids#2202copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_929301731
branch
3 times, most recently
from
June 9, 2026 21:33
295d28a to
e59c3c9
Compare
…m grids Switch the inner face gradient stencil from left-right-rightright to leftleft-left-right for all faces except the first inner face (which retains the right-biased stencil since no leftleft cell exists). This prevents pedestal values from contaminating core gradient calculations on non-uniform grids, where the rightright cell could reach across the pedestal boundary. Both stencils are second-order accurate. On uniform grids they are mathematically equivalent. PiperOrigin-RevId: 929301731
copybara-service
Bot
force-pushed
the
test_929301731
branch
from
June 9, 2026 21:58
e59c3c9 to
eba9789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: use left-biased 3-point stencil for face gradients on non-uniform grids
Switch the inner face gradient stencil from left-right-rightright to
leftleft-left-right for all faces except the first inner face (which
retains the right-biased stencil since no leftleft cell exists).
This prevents pedestal values from contaminating core gradient
calculations on non-uniform grids, where the rightright cell could
reach across the pedestal boundary.
Both stencils are second-order accurate. On uniform grids they are
mathematically equivalent.