Bugfix: data pipeline drops chain descriptions#677
Closed
ntnn19 wants to merge 6 commits into
Closed
Conversation
Collaborator
|
Nice catch, thanks! I've pushed the fix in b712a3d, I will make sure to mention you in the release notes for the next version. (Thank you also for the responsible AI usage disclosure!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug:
DataPipeline.process_protein_chain()andprocess_rna_chain()reconstruct chain objects without forwarding thedescriptionfield, silently dropping descriptions provided in the input JSON.RnaChain.fill_missing_fields()has the same omission.The fix: Add
description=chain.descriptionto the return statements in all three methods.This preserves chain descriptions throughout the data pipeline and during
fill_missing_fields().AI usage disclosure: AI tools were used to assist in generating parts of the code and PR description. The resulting changes were manually reviewed, edited, and tested by the author before submission.