Skip to content

Adding gemini-cli pkg#204

Merged
jessie-minimal merged 3 commits into
mainfrom
gemini
May 29, 2026
Merged

Adding gemini-cli pkg#204
jessie-minimal merged 3 commits into
mainfrom
gemini

Conversation

@jessie-minimal
Copy link
Copy Markdown
Member

@jessie-minimal jessie-minimal commented May 29, 2026

Summary

Related issues

Changes

Checklist

  • I've read CONTRIBUTING.md.
  • I've accepted the ICLA (and CCLA if contributing on my employer's time). CLA Assistant will prompt me on this PR if I haven't already.
  • min check passes for the affected packages/harnesses.
  • min patched-build <name> succeeds for any package I added or modified.
  • For new packages: source_provenance points to the canonical upstream and the source builds from source (not a prebuilt release binary) where the required toolchain is available.
  • For version bumps: I've verified the new sha256 against the upstream archive.

Notes for reviewers

Summary by CodeRabbit

  • Chores
    • Added packaging and install support for a gemini CLI (pinned to v0.44.1) with writable user-state mapping.
    • Bumped runtime/tool versions: Deno → 2.8.1, libxml2 → 2.15.3, pnpm → 10.33.4, Ruby → 4.0.5, util-linux → 2.42.1; updated related package metadata.
  • Tests
    • Added smoketests: version check and help/output validation.

Review Change Stack

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 29, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds a new gemini-cli BuildSpec and build.sh to install @google/gemini-cli@0.44.1, and updates upstream versions and checksums for deno, libxml2, pnpm, ruby, and util-linux; pnpm and ruby gains license metadata.

Changes

Gemini CLI Package Build

Layer / File(s) Summary
BuildSpec header and version
packages/gemini-cli/build.ncl
Adds imports and pins version = "0.44.1" for the BuildSpec.
BuildSpec wiring and outputs
packages/gemini-cli/build.ncl
Defines BuildSpec with build_deps/runtime_deps, needs = ["dns","internet"], runs ./build.sh with version in build_args, and maps outputs for usr/bin/gemini and usr/lib/node_modules/**.
Tests and package attributes
packages/gemini-cli/build.ncl
Adds tests (version smoketest and help/grep) and sets attrs including upstream_version, source_provenance (GithubRepo), and env_dir_mappings for ~/.gemini.
Bash build script (npm install)
packages/gemini-cli/build.sh
Strict-mode Bash script that runs npm install @google/gemini-cli@${MINIMAL_ARG_VERSION} --prefix $OUTPUT_DIR/usr to install into the package prefix.

Upstream package version bumps

Layer / File(s) Summary
Deno version and checksums
packages/deno/build.ncl
Bumps Deno from 2.7.13 to 2.8.1 and updates x86_64 and arm64 sha256 values.
libxml2 version bump
packages/libxml2/build.ncl
Bumps libxml2 to 2.15.3 and updates the source tarball sha256.
pnpm version and metadata
packages/pnpm/build.ncl
Bumps pnpm to 10.33.4, updates tarball sha256, and adds license_spdx = "MIT".
Ruby version and build script
packages/ruby/build.ncl, packages/ruby/build.sh
Bumps Ruby to 4.0.5, updates tarball sha256, adds license_spdx = "Ruby", and updates build.sh extraction paths to 4.0.5.
util-linux version bump
packages/util-linux/build.ncl
Bumps util-linux to 2.42.1 and updates the source archive sha256.

Sequence Diagram

sequenceDiagram
  participant BuildSpec
  participant BuildScript
  participant npm
  participant OutputDir
  BuildSpec->>BuildScript: run ./build.sh with version arg
  BuildScript->>npm: npm install `@google/gemini-cli`@${MINIMAL_ARG_VERSION} --prefix $OUTPUT_DIR/usr
  npm->>OutputDir: install usr/bin/gemini and usr/lib/node_modules/**
Loading

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • jtnkminimal
  • msample

"A rabbit taps the build, so spry,
pins versions neat beneath the sky,
npm hops in, files take their place,
checksums dance, and tests embrace,
tiny paws deliver the supply."

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Adding gemini-cli pkg' accurately reflects the primary change: introduction of a new gemini-cli package with build configuration and scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gemini

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/gemini-cli/build.sh`:
- Line 4: The npm install command in build.sh uses unquoted variables which can
break on paths with spaces or special chars; update the line invoking npm
install -g --prefix=$OUTPUT_DIR/usr `@google/gemini-cli`@$MINIMAL_ARG_VERSION to
quote the variables (e.g. --prefix="$OUTPUT_DIR/usr" and
"`@google/gemini-cli`@$MINIMAL_ARG_VERSION") so $OUTPUT_DIR and
$MINIMAL_ARG_VERSION are protected from word splitting and globbing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ec1501f5-0fb2-49c7-815b-f84374fa1103

📥 Commits

Reviewing files that changed from the base of the PR and between 3ae4553 and 281b8ba.

📒 Files selected for processing (2)
  • packages/gemini-cli/build.ncl
  • packages/gemini-cli/build.sh

Comment thread packages/gemini-cli/build.sh Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/gemini-cli/build.sh`:
- Line 4: The npm install line uses legacy backticks around the package name
causing command substitution; update the npm install command (the npm install -g
--prefix... invocation that uses the MINIMAL_ARG_VERSION and OUTPUT_DIR
variables) to pass the literal package spec rather than using backticks—remove
the backticks and quote the package spec so it becomes
`@google/gemini-cli`@"$MINIMAL_ARG_VERSION" (or wrap the entire package spec in
single or double quotes) so npm receives the correct package string.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9d69884b-736b-4807-8f4f-e0d2c926e3c7

📥 Commits

Reviewing files that changed from the base of the PR and between 52cf417 and 0855e25.

📒 Files selected for processing (1)
  • packages/gemini-cli/build.sh

Comment thread packages/gemini-cli/build.sh Outdated
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment thread packages/gemini-cli/build.ncl
@jessie-minimal jessie-minimal added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 393b5ce May 29, 2026
4 checks passed
@jessie-minimal jessie-minimal deleted the gemini branch May 29, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants