Adding gemini-cli pkg#204
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new gemini-cli BuildSpec and build.sh to install ChangesGemini CLI Package Build
Upstream package version bumps
Sequence DiagramsequenceDiagram
participant BuildSpec
participant BuildScript
participant npm
participant OutputDir
BuildSpec->>BuildScript: run ./build.sh with version arg
BuildScript->>npm: npm install `@google/gemini-cli`@${MINIMAL_ARG_VERSION} --prefix $OUTPUT_DIR/usr
npm->>OutputDir: install usr/bin/gemini and usr/lib/node_modules/**
🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/gemini-cli/build.sh`:
- Line 4: The npm install command in build.sh uses unquoted variables which can
break on paths with spaces or special chars; update the line invoking npm
install -g --prefix=$OUTPUT_DIR/usr `@google/gemini-cli`@$MINIMAL_ARG_VERSION to
quote the variables (e.g. --prefix="$OUTPUT_DIR/usr" and
"`@google/gemini-cli`@$MINIMAL_ARG_VERSION") so $OUTPUT_DIR and
$MINIMAL_ARG_VERSION are protected from word splitting and globbing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ec1501f5-0fb2-49c7-815b-f84374fa1103
📒 Files selected for processing (2)
packages/gemini-cli/build.nclpackages/gemini-cli/build.sh
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/gemini-cli/build.sh`:
- Line 4: The npm install line uses legacy backticks around the package name
causing command substitution; update the npm install command (the npm install -g
--prefix... invocation that uses the MINIMAL_ARG_VERSION and OUTPUT_DIR
variables) to pass the literal package spec rather than using backticks—remove
the backticks and quote the package spec so it becomes
`@google/gemini-cli`@"$MINIMAL_ARG_VERSION" (or wrap the entire package spec in
single or double quotes) so npm receives the correct package string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9d69884b-736b-4807-8f4f-e0d2c926e3c7
📒 Files selected for processing (1)
packages/gemini-cli/build.sh
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
Related issues
Changes
Checklist
min checkpasses for the affected packages/harnesses.min patched-build <name>succeeds for any package I added or modified.source_provenancepoints to the canonical upstream and the source builds from source (not a prebuilt release binary) where the required toolchain is available.sha256against the upstream archive.Notes for reviewers
Summary by CodeRabbit