feat: modal draft - #19
Draft
golota60 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for modals;
There's a problem with those which i am yet to figure out the best solution for. The problem is: in order to display a modal, we need it to be the topmost level component, so that we can always center it and use a semi-transparent background for a backdrop. But here's the thing - there's no good way to do this.
The potential solution: expose a
modal_wrapper/oxytail_wrapper(if we want to be more general)that will wrap our app in a vertical stack with a dummy "modal container" accessible globally. Next, when we want to render a modal, we simply get that global container, and put our modal data into it. This solution is not ideal for two reasons: