Remove deleted agent provision configs during component updates#3473
Merged
Conversation
vigoo
reviewed
May 19, 2026
| #[error("Multiple agent types with the same name: {0}")] | ||
| DuplicateAgentTypeName(AgentTypeName), | ||
| #[error( | ||
| "Agent type '{0}' is referenced in provision config but not declared in the component's agent types" |
Contributor
There was a problem hiding this comment.
The reason why this error was so confusing, I think, is that the term "provision config" is never shown to the user anywhere else (or is it)
Contributor
Author
There was a problem hiding this comment.
Agree, it should be an internal name only. On the other hand, this is a "should not happen" error, meaning either CLI or server side bug, not fixable by the user.
vigoo
approved these changes
May 19, 2026
mschuwalow
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3446 + adds invariant checks before saving metadata