x/image/font/sfnt: fix io.EOF in ParseReaderAt on fonts with useMarkFilteringSet#32
x/image/font/sfnt: fix io.EOF in ParseReaderAt on fonts with useMarkFilteringSet#32matstech wants to merge 1 commit into
Conversation
with useMarkFilteringSet The flag check in parseGPOSKern happened after the extension lookup (type 9), causing io.EOF. Moving the check to the top of case 9 fixes the issue. Fixes golang/go#79489
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR (HEAD: 557b4f2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/image/+/779862. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/779862. |
|
Hey guys, is 1:30 in the morning can I get some rest please? I went to bed hotOn May 20, 2026, at 01:12, GopherBot ***@***.***> wrote:gopherbot left a comment (golang/image#32)
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/779862.
After addressing review feedback, remember to publish your drafts!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Fixes an io.EOF returned by ParseReaderAt when parsing fonts with a
GPOS Extension lookup (type 9) and the useMarkFilteringSet flag set.
Fixes golang/go#79489