bmp: add pixel count limit for large dimensions#28
Open
TristanInSec wants to merge 1 commit into
Open
Conversation
The BMP decoder does not validate the relationship between width and height values read from the file header. Very large dimensions can cause image.New* to panic instead of returning an error. Add a pixel count check (1<<30, approximately 1 billion pixels) to convert this panic into a proper error return. This is consistent with the TIFF decoder's maxChunkSize approach for bounding allocations from untrusted input.
Contributor
|
This PR (HEAD: 6caeaa3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/image/+/759701. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/759701. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BMP decoder does not validate the relationship between
widthandheightvalues read from the file header. Very large dimensions can causeimage.New*to panic with "huge or negative dimensions" instead of returning a proper error.This change adds a pixel count check (
int64(width)*int64(height) > 1<<30) to convert this panic into a proper error return. The limit (~1 billion pixels, ~4 GiB at 4 bytes per pixel) still permits images well beyond typical BMP usage.This is consistent with the TIFF decoder's
maxChunkSizeapproach for bounding allocations from untrusted input.Change: 8 lines added to
bmp/reader.go.