Skip to content

net/http: count a lost HTTP/2 ping exactly once, and never on a failed connection - #80923

Open
ali-sayyah wants to merge 1 commit into
golang:masterfrom
ali-sayyah:http2-close-healthcheck
Open

net/http: count a lost HTTP/2 ping exactly once, and never on a failed connection#80923
ali-sayyah wants to merge 1 commit into
golang:masterfrom
ali-sayyah:http2-close-healthcheck

Conversation

@ali-sayyah

@ali-sayyah ali-sayyah commented Aug 17, 2026

Copy link
Copy Markdown

The HTTP/2 health-check timer is re-armed after every ReadFrame
return, including the final erroring one, and no close path stops it:
one SendPingTimeout after every connection close a post-mortem health
check pings the dead connection, fails immediately, and reports a
spurious CountError("conn_close_lost_ping"). A genuinely lost ping is
counted twice: the real detection, then the post-close echo.

Stop the timer when the read loop exits, publish the read loop's
terminal exit under cc.mu before the failure is counted, and make
lost-ping classification a single-claim close: the eligibility check
and the claim share one critical section in closeForLostPing, so
overlapping health checks, or a ping racing the read loop's terminal
exit, can never produce a second count. The CountError callback runs
outside the lock. A ping that fails on a connection that is live at
claim time is still counted and still closes the connection,
preserving write-blocked-ping detection.

The equivalent x/net change (golang/net#262) fixes the legacy
transport used on Go versions before 1.27 and with the http2legacy
build tag.

Fixes #80920

@google-cla

google-cla Bot commented Aug 17, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…d connection

The HTTP/2 health-check timer is re-armed after every ReadFrame
return, including the final erroring one, and no close path stops it:
one SendPingTimeout after every connection close a post-mortem health
check pings the dead connection, fails immediately, and reports a
spurious CountError("conn_close_lost_ping"). A genuinely lost ping is
counted twice: the real detection, then the post-close echo.

Stop the timer when the read loop exits, publish the read loop's
terminal exit under cc.mu before the failure is counted, and make
lost-ping classification a single-claim close: the eligibility check
and the claim share one critical section in closeForLostPing, so
overlapping health checks, or a ping racing the read loop's terminal
exit, can never produce a second count. The CountError callback runs
outside the lock. A ping that fails on a connection that is live at
claim time is still counted and still closes the connection,
preserving write-blocked-ping detection.

The equivalent x/net change (golang/net#262) fixes the legacy
transport used on Go versions before 1.27 and with the http2legacy
build tag.

Fixes golang#80920
@ali-sayyah
ali-sayyah force-pushed the http2-close-healthcheck branch from 957dad6 to 7458cda Compare August 17, 2026 20:14
@ali-sayyah ali-sayyah changed the title net/http: don't count lost pings on terminally failed connections net/http: count a lost HTTP/2 ping exactly once, and never on a failed connection Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/net/http2: Transport health check fires after connection close, counting a spurious conn_close_lost_ping for every closed connection

1 participant