Skip to content

encoding/json/v2: optimize IsZero method resolution for omitzero (fix #80868) - #80887

Closed
SparshGarg999 wants to merge 1 commit into
golang:masterfrom
SparshGarg999:fix-jsonv2-iszero-omitzero-alloc-80868
Closed

encoding/json/v2: optimize IsZero method resolution for omitzero (fix #80868)#80887
SparshGarg999 wants to merge 1 commit into
golang:masterfrom
SparshGarg999:fix-jsonv2-iszero-omitzero-alloc-80868

Conversation

@SparshGarg999

@SparshGarg999 SparshGarg999 commented Aug 15, 2026

Copy link
Copy Markdown

Fixes #80868

Context & Problem

When marshalling structs tagged with omitzero using encoding/json/v2, if a field's underlying type implements IsZero() bool on a pointer receiver (e.g., func (t *MyType) IsZero() bool), encoding/json/v2 previously evaluated value IsZero method resolution before checking pointer receiver methods. This caused reflection to construct an addressable copy on the heap, triggering two extra allocations per field during struct marshalling.

Solution & Changes

  • Reordered IsZero method resolution in src/encoding/json/v2/fields.go to test for pointer-receiver IsZero implementations first before value-receiver fallback.
  • Eliminates temporary heap allocations when evaluating omitzero fields implementing IsZero.

Testing & Verification

  • Benchmarked json.Marshal allocations on omitzero structs with pointer-receiver IsZero methods, verifying zero extra allocations.

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 27cb769) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/814683.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

encoding/json/v2: Unnecessary allocation marshalling struct with IsZero method and omitzero

2 participants