Skip to content

math/big: fix Int.Divide remainder calculation when r aliases y (fix #80882) - #80886

Closed
SparshGarg999 wants to merge 1 commit into
golang:masterfrom
SparshGarg999:fix-math-big-divide-aliasing-80882
Closed

math/big: fix Int.Divide remainder calculation when r aliases y (fix #80882)#80886
SparshGarg999 wants to merge 1 commit into
golang:masterfrom
SparshGarg999:fix-math-big-divide-aliasing-80882

Conversation

@SparshGarg999

@SparshGarg999 SparshGarg999 commented Aug 15, 2026

Copy link
Copy Markdown

Fixes #80882

Context & Problem

In math/big, calling Int.Divide(x, y, y, mode) evaluates quotient q into the destination receiver before computing remainder r. When remainder destination r aliases divisor y, mutating y/r during quotient evaluation causes the subsequent remainder calculation r = x - y*q to evaluate using an already mutated divisor, producing incorrect remainder values.

Solution & Changes

  • Updated Int.Divide in src/math/big/int.go to handle remainder receiver aliasing with the divisor parameter by staging remainder computations before mutating aliased quotient/divisor targets.

Testing & Verification

  • Added test cases in src/math/big/int_test.go verifying ceiling, floor, and truncation division when remainder destination aliases the divisor (q, r := q.Divide(x, y, y, big.Ceil)).

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 9839890) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/815740.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

math/big: Int.Divide returns an incorrect remainder when r aliases y

2 participants