net: shuffle resolved IP addresses for load balancing - #76658
net: shuffle resolved IP addresses for load balancing#76658AnonyScorpio wants to merge 1 commit into
Conversation
|
This PR (HEAD: 4e20e55) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Vi Leon: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
@ianlancetaylor here |
|
Message from Ian Lance Taylor: Patch Set 1: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Sean Liao: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
This PR (HEAD: fcb5cb2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Vi Leon: Patch Set 2: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-08-04T20:44:28Z","revision":"32ae2d79488def40a65536abbfa0d829c2f81692"} Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Vi Leon: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: LUCI-TryBot-Result-1 Copied votes on follow-up patch sets have been updated:
Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-08-04T20:53:04Z","revision":"07d630a5fd29c1257c801b8326746d5c7320f04f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5206>) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64-boringcrypto has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Vi Leon: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
This PR (HEAD: af94d29) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Vi Leon: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
This PR (HEAD: 33219e5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
This PR (HEAD: 8f936f4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Vi Leon: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 9: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 9: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
This PR (HEAD: 808a73e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Vi Leon: Patch Set 10: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
This PR (HEAD: 62aa738) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
This PR (HEAD: 8613aa9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
This PR (HEAD: 8e1a6a6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
This PR (HEAD: 3045896) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Ian Lance Taylor: Patch Set 14: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
This PR (HEAD: f587cee) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Vi Leon: Patch Set 15: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Vi Leon: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Sean Liao: Patch Set 15: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Ian Lance Taylor: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
This PR (HEAD: 9dd5e9d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Vi Leon: Patch Set 16: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
|
Message from Sean Liao: Patch Set 16: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
Resolved addresses are now shuffled before sorting per RFC 6724, so concurrent callers do not always receive the same order. This helps distribute network connections across multiple addresses. The address slice is now always cloned before returning, allowing the caller to mutate it safely even when results are shared by concurrent singleflight callers. Fixes golang#31698
|
This PR (HEAD: d9ad3da) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725960. Important tips:
|
|
Message from Vi Leon: Patch Set 17: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725960. |
Resolved addresses are now shuffled before sorting per RFC 6724,
so concurrent callers do not always receive the same order.
This helps distribute network connections across multiple addresses.
The address slice is now always cloned before returning,
allowing the caller to mutate it safely even when results are shared
by concurrent singleflight callers.
Fixes #31698