[Chaitanya] Implement #215: Feat: Pinecone as a datasource plugin#216
Draft
deepesh-dg wants to merge 1 commit into
Draft
[Chaitanya] Implement #215: Feat: Pinecone as a datasource plugin#216deepesh-dg wants to merge 1 commit into
deepesh-dg wants to merge 1 commit into
Conversation
Collaborator
Author
Implementation StartedI've analyzed the issue and created an implementation plan ( The plan file has been written. Here's a summary of what's in What the plan covers8 files to create, 1 file to modify:
Key design decisions documented in the plan:
Now proceeding with implementation based on this plan. Branch: |
Collaborator
Author
Implementation FailedAn error occurred while processing this issue. The draft PR has been left for manual handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #215: Feat: Pinecone as a datasource plugin
The Problem
Developers building AI/RAG (Retrieval-Augmented Generation) applications with Godspeed need to store and retrieve vector embeddings for semantic search, similarity matching, and long-term memory layers. There is currently no official Godspeed plugin for Pinecone — a leading managed vector database. Teams are forced to write custom integration code outside the framework's declarative datasource pattern, losing the benefits of unified config, lifecycle management, and workflow composability.
The Solution
A new official plugin:
@godspeedsystems/plugins-pinecone-as-datasourcethat integrates Pinecone as a Godspeed DataSource.Developers should be able to:
What this does not do?
How will we solve
Follow the standard Godspeed
DataSourceplugin pattern (GSDataSourcebase class from@godspeedsystems/core) with:initClient()— establish Pinecone client and ensure the configured index existsexecute(ctx, args)— dispatch to the appropriate operation based onargs.methodPlugin lives at
plugins/pinecone-as-datasource/in this repo.Any Special Considerations or Assumptions
apiKeyis not provided — do not silently fall back.namespacefall back to a'default'namespace to keep behavior predictable.cloud+region). Pod-based index support is a future improvement.Impact Areas
@godspeedsystems/coreREADME.mdTest Cases
insert: single document is upserted; response includesid,indexName, andnamespaceinsert: batch of documents is upserted in one callquery: returns up totopKmatches withid,score, andmetadataquery: results respect namespace isolation — documents in namespace A are not returned by a query scoped to namespace Bquery: metadata filter correctly limits resultsupdate: merges new metadata with existing metadata without overwriting unrelated fieldsupdate: replaces vector values when new values are supplieddelete: removes a single vector by iddelete: removes multiple vectors by id listdelete: removes vectors matching a metadata filterdeleteIndex: deletes the index; subsequent init recreates itFuture Improvements
describeIndexmethodDefinition of Done (DoD)
plugins/pinecone-as-datasource/following the standard structure (src/index.ts,package.json,tsconfig.json,README.md,.gitignore,.npmignore)@godspeedsystems/plugins-pinecone-as-datasourceand published to npmexecute():insert,update,delete,deleteIndex,queryDataSource(default),SourceType,Type,CONFIG_FILE_NAME,DEFAULT_CONFIGDEFAULT_CONFIGdocuments every supported config key with its default valuenpm run build)README.mdcovers: installation, full config YAML schema with all options, each method with an example workflow snippetREADME.mdImplementation Plan
The plan file has been written. Here's a summary of what's in
CHAITANYA_ISSUE_215_PLAN.md:What the plan covers
8 files to create, 1 file to modify:
plugins/pinecone-as-datasource/src/index.tsDataSourceclass withinitClient(),execute(), and 5 private method helpers (_insert,_query,_update,_delete,_deleteIndex). Exact TypeScript pasted in.src/__tests__/index.test.tspackage.json@godspeedsystems/plugins-pinecone-as-datasourcev1.0.0, with@pinecone-database/pinecone ^3.0.0as a dep andjest/ts-jest/@types/jestas devDeps.tsconfig.json"./src/__tests__"inexcludeso tests don't land indist/.jest.config.jsts-jestpreset,clearMocks: true(critical for isolation between tests).README.md.gitignore/.npmignore.npmignorealso excludesjest.config.js.README.mdKey design decisions documented in the plan:
fnNameInWorkflow.split('.')[2](standard pattern) withargs.methodfallbacknamespacedefaults to"default"— never empty stringinitClient()throws on missingapiKey(fast-fail, correct Godspeed startup pattern)waitUntilReady: trueon index creationupdateuses Pinecone SDK'ssetMetadata(merges, doesn't overwrite) — notupsertclearMocks,unknownvsany, etc.)Implementation in progress by Chaitanya AI...