Update Android NDK version in export-android.md#146
Conversation
Update Android NDK version in export-android.md
|
Thank you! This is bound to become outdated again; I wonder if we should just point to the link |
|
Thank you for replying! I 100% agree with you. Should I open another pr without hard-coding ndk version? Since this is my first time pr, I'm not used to pr protocol yet. |
|
No, please don't open a new PR 🙂 And then check if everything is correct: If yes, force-push to update this branch here: git push --force-with-lease |
Updated NDK version reference for clarity.
|
Thanks for the instructions! I removed version specification and made the sentence simple. Please let me know if there are any issues. |
Bromeon
left a comment
There was a problem hiding this comment.
I would mention the key type, just so it's immediately clear what to look for 🙂
| 1. Android CLI is installed in the `$HOME` folder. | ||
| 2. Godot is still relying on Android NDK version 23.2.8568313. Check | ||
| [here](https://github.com/godotengine/godot/blob/master/platform/android/java/app/config.gradle). | ||
| 2. The NDK version is [here](https://github.com/godotengine/godot/blob/master/platform/android/java/app/config.gradle). |
There was a problem hiding this comment.
| 2. The NDK version is [here](https://github.com/godotengine/godot/blob/master/platform/android/java/app/config.gradle). | |
| 2. The NDK version is specified [here](https://github.com/godotengine/godot/blob/master/platform/android/java/app/config.gradle), | |
| under key `ndkVersion`. |
There was a problem hiding this comment.
Thank you! That looks a lot better!
|
With key type, that looks a lot better! |
7332cd3 to
df24ed3
Compare
Description
This PR updates an outdated reference to the Android NDK version in the Android export documentation (
toolchain/export-android.md).The document previously stated that Godot relies on NDK version
23.2.8568313, which is outdated. It has been updated to reference the correct current version,29.0.14206865.Changes
23.2.8568313to29.0.14206865in the Android export example.Checklist