feat: support explicit move colors for handicap games#75
Merged
Conversation
Includes fix for handicap game move color assignment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add MoveInput enum that accepts both formats: - Simple: ["D4", "Q16"] - colors inferred from alternation - Explicit: [["W", "D4"], ["B", "Q16"]] - colors specified directly This fixes analysis for handicap games where KataGo ignores initialPlayer for positions with moves and assumes Black-first alternation. Clients can now send explicit colors to ensure correct perspective for winrate and territory. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MoveInputenum that accepts both move formats in the analysis API["D4", "Q16"]- colors inferred from alternation[["W", "D4"], ["B", "Q16"]]- colors specified directlyProblem
KataGo ignores
initialPlayerfor positions with 1+ moves, always assuming Black plays first. This causes incorrect perspective for winrate and territory in handicap games where White plays first.Solution
Allow clients to send explicit
[color, coordinate]pairs so KataGo receives the correct move colors, ensuring proper analysis perspective for handicap games.Test plan
🤖 Generated with Claude Code