fix: health endpoint now checks KataGo process status#72
Merged
Conversation
- Health endpoint returns 503 when KataGo process is not alive - Fixed query_version requests to include required 'id' field - Fixes keepalive ping error spam in KataGo logs every 30 seconds The health endpoint previously always returned 200 OK regardless of whether KataGo was actually running. Now it properly checks the process_alive flag and returns 503 Service Unavailable when KataGo has crashed, allowing Salad Cloud liveness probes to trigger restarts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query_versionrequests to include requiredidfieldProblem
The health endpoint was always returning
200 OKwith"status": "healthy"even when the KataGo process had crashed. This prevented Salad Cloud's liveness probes from detecting failures and restarting the container.Additionally, the keepalive ping was sending malformed requests without the required
idfield, causing error log spam:Solution
engine.is_alive()and returns503 Service Unavailablewhen KataGo is not runningidfield to keepalive ping andquery_versionrequests per KataGo protocol requirementsTest plan
🤖 Generated with Claude Code