Skip to content

lib/logging: only show locals when in debug mode#16772

Merged
rissson merged 1 commit into
mainfrom
lib/logging-hide-locals
Sep 15, 2025
Merged

lib/logging: only show locals when in debug mode#16772
rissson merged 1 commit into
mainfrom
lib/logging-hide-locals

Conversation

@BeryJu

@BeryJu BeryJu commented Sep 15, 2025

Copy link
Copy Markdown
Member

Details

Only show locals in debug mode. Previous setup can be used in certain configurations to leak partial passwords in the log


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
BeryJu requested a review from a team as a code owner September 15, 2025 12:59
@BeryJu BeryJu added backport/version-2025.8 Add this label to PRs to backport changes to version-2025.8 backport/version-2025.6 labels Sep 15, 2025
@netlify

netlify Bot commented Sep 15, 2025

Copy link
Copy Markdown

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit c3140be
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68c80d9f2703050008018d7f

@netlify

netlify Bot commented Sep 15, 2025

Copy link
Copy Markdown

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit c3140be
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68c80d9f7188d700082050a2
😎 Deploy Preview https://deploy-preview-16772--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 15, 2025

Copy link
Copy Markdown

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit c3140be
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68c80d9f8726e200088b7727

@codecov

codecov Bot commented Sep 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (f565803) to head (c3140be).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16772      +/-   ##
==========================================
+ Coverage   92.77%   92.83%   +0.05%     
==========================================
  Files         838      838              
  Lines       45371    45371              
==========================================
+ Hits        42094    42119      +25     
+ Misses       3277     3252      -25     
Flag Coverage Δ
e2e 46.58% <ø> (+0.08%) ⬆️
integration 23.51% <ø> (+<0.01%) ⬆️
unit 90.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson
rissson merged commit 68a2332 into main Sep 15, 2025
157 of 159 checks passed
@rissson
rissson deleted the lib/logging-hide-locals branch September 15, 2025 13:33
@authentik-automation

Copy link
Copy Markdown
Contributor

🍒 Cherry-pick to version-2025.8 created: #16774

@authentik-automation

Copy link
Copy Markdown
Contributor

🍒 Cherry-pick to version-2025.6 created: #16775

rissson pushed a commit that referenced this pull request Sep 15, 2025
rissson pushed a commit that referenced this pull request Sep 15, 2025
@github-actions

Copy link
Copy Markdown
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-c3140be422f7849c656e331c2593d42e65defa11
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-c3140be422f7849c656e331c2593d42e65defa11

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu
BeryJu restored the lib/logging-hide-locals branch September 26, 2025 16:04
@BeryJu
BeryJu deleted the lib/logging-hide-locals branch September 26, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/version-2025.8 Add this label to PRs to backport changes to version-2025.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants