Skip to content

core: fix client-side only validation allowing admin to set blank user password#16467

Merged
BeryJu merged 1 commit into
mainfrom
core/fix-users-empty-password-allowed
Aug 29, 2025
Merged

core: fix client-side only validation allowing admin to set blank user password#16467
BeryJu merged 1 commit into
mainfrom
core/fix-users-empty-password-allowed

Conversation

@BeryJu

@BeryJu BeryJu commented Aug 29, 2025

Copy link
Copy Markdown
Member

Details

Previously was only relying on client-side validation


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@BeryJu
BeryJu requested review from a team as code owners August 29, 2025 12:40
@netlify

netlify Bot commented Aug 29, 2025

Copy link
Copy Markdown

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 6e6566d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68b1a0a0800d2a0008f493b2

@BeryJu BeryJu added backport/version-2025.8 Add this label to PRs to backport changes to version-2025.8 backport/version-2025.6 labels Aug 29, 2025
@netlify

netlify Bot commented Aug 29, 2025

Copy link
Copy Markdown

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit 6e6566d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68b1a0a0a7926900089b8222

@netlify

netlify Bot commented Aug 29, 2025

Copy link
Copy Markdown

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 6e6566d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68b1a0a0f1fc650008d2f890

…r password

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
BeryJu force-pushed the core/fix-users-empty-password-allowed branch from 1f6938a to 6e6566d Compare August 29, 2025 12:44
@codecov

codecov Bot commented Aug 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (665cbd2) to head (6e6566d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16467   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         838      838           
  Lines       45295    45304    +9     
=======================================
+ Hits        42025    42035   +10     
+ Misses       3270     3269    -1     
Flag Coverage Δ
e2e 46.57% <20.00%> (-0.01%) ⬇️
integration 23.53% <20.00%> (+<0.01%) ⬆️
unit 90.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu
BeryJu enabled auto-merge (squash) August 29, 2025 13:06
@BeryJu
BeryJu merged commit 180cec9 into main Aug 29, 2025
107 checks passed
@BeryJu
BeryJu deleted the core/fix-users-empty-password-allowed branch August 29, 2025 13:07
authentik-automation Bot pushed a commit that referenced this pull request Aug 29, 2025
…r password (#16467)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@authentik-automation

Copy link
Copy Markdown
Contributor

🍒 Cherry-pick to version-2025.8 created: #16469

authentik-automation Bot pushed a commit that referenced this pull request Aug 29, 2025
This cherry-pick has conflicts that need manual resolution.

Original PR: #16467
Original commit: 180cec9
@authentik-automation

Copy link
Copy Markdown
Contributor

⚠️ Cherry-pick to version-2025.6 has conflicts: #16470

@github-actions

Copy link
Copy Markdown
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-6e6566d811578e0982b11a7617d3a745c5c8e08e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-6e6566d811578e0982b11a7617d3a745c5c8e08e

Afterwards, run the upgrade commands from the latest release notes.

rissson pushed a commit that referenced this pull request Aug 29, 2025
…r password (cherry-pick #16467) (#16469)

Co-authored-by: Jens L. <jens@goauthentik.io>
fix client-side only validation allowing admin to set blank user password (#16467)
BeryJu added a commit that referenced this pull request Aug 29, 2025
This cherry-pick has conflicts that need manual resolution.

Original PR: #16467
Original commit: 180cec9

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Sep 19, 2025
* main: (71 commits)
  website: Redirect Azure to Entra. Add tags for search indexing. (#16474)
  website: Page redirect guide, documentation (#16466)
  root: bump openapi-generator-cli to v7.15.0 (#16440)
  ci: bump actions/attest-build-provenance from 2 to 3 (#16462)
  core: bump astral-sh/uv from 0.8.13 to 0.8.14 (#16461)
  ci: remove Python client API publication (#16468)
  website: Unify Netlify redirects with Docusaurus's client-side router. (#16430)
  core: fix client-side only validation allowing admin to set blank user password (#16467)
  website/integrations: Update Issuer URL for Immich (#16460)
  providers/oauth2: include scope in JWT (#16454)
  lib/sync/outgoing: fix single object sync timeout (#16447)
  website/docs: capitalized proper name of stages, removed old version references. (#16414)
  web: bump pino-pretty from 13.0.0 to 13.1.1 in /web (#16411)
  core: bump h2 from 4.2.0 to 4.3.0 (#16446)
  web: bump @playwright/test from 1.54.1 to 1.55.0 in /web (#16413)
  web: bump the react group across 2 directories with 1 update (#16448)
  web: bump bootstrap from 5.3.7 to 5.3.8 in /web (#16416)
  web: bump @sentry/browser from 10.6.0 to 10.7.0 in /web in the sentry group across 1 directory (#16433)
  root: check for brew install of libxml2 before updating path (#16422)
  core: bump github.com/stretchr/testify from 1.11.0 to 1.11.1 (#16434)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/version-2025.8 Add this label to PRs to backport changes to version-2025.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants