feat(security): added containment options and predefined secure loaders#145
Merged
Merged
Conversation
The loaders may now be constrained to prevent the spec loading to escape from a local root or to escape to forbidden URLs. Defaults remain unaffected and insecure: this avoids breaking changes. The default use case for this library is not guard against uncontrolled adversarial specs but to easily load a spec the user knows. We expose the new contained options and loaders for users who'd like to use this library in a more open context, where the source is not necessarily trusted. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
cdf8099 to
87cc26d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 80.78% 82.86% +2.08%
==========================================
Files 4 5 +1
Lines 229 286 +57
==========================================
+ Hits 185 237 +52
- Misses 28 31 +3
- Partials 16 18 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loaders may now be constrained to prevent the spec loading to escape from a local root or to escape to forbidden URLs.
Defaults remain unaffected and insecure: this avoids breaking changes.
The default use case for this library is not guard against uncontrolled adversarial specs but to easily load a spec the user knows.
We expose the new contained options and loaders for users who'd like to use this library in a more open context, where the source is not necessarily trusted.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist