Add gorm dialect for db_pem_storer#92
Merged
zachmann merged 4 commits intoJun 10, 2026
Merged
Conversation
- Remove unnecessary helper function for dialect mapping. - Directly use db.Dialector.Name() for column type determination. - Enhance test coverage for GormDBDataType with a fake dialector.
Contributor
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go | Jun 10, 2026 7:06a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
zachmann
requested changes
Jun 10, 2026
zachmann
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #83 (comment)
Adds a new
GormDBDataTypeselectorto swap the schema for DB based pems to a data type for MySQL and a best guess equivlaents in sqlite forbytea.After this change, I was able to pass the migration from file-system to db backed pem storage:
I also added some test cases, but they seems pretty meh