table/server: soft-delete logic and guards for org-units (#181)#187
Conversation
…e-stack#181) Add data model changes and API guards for org-unit soft-delete: - Add Deleted int64 field to OrgUnitEntry (bson:"deleted,omitempty") - Implement DeleteOrgUnit: sets deleted timestamp when allow_ou_delete is enabled, idempotent for already-deleted OUs - Guard UpdateOrgUnit: return FailedPrecondition if OU is deleted - Guard AddOrgUnitUser: reject user additions to deleted OUs - Wire status/deleted fields into GetOrgUnit and ListOrgUnits responses - Thread ExperimentalConfig into OrgUnitServer and OrgUnitUserServer
|
Warning Review limit reached
More reviews will be available in 42 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Implements the data model changes and API guards for org-unit soft-delete (issue #181).
Changes:
pkg/table/org-unit.go: AddDeleted int64field toOrgUnitEntrywithbson:"deleted,omitempty"— zero value (active) means the field is omitted from MongoDB documentspkg/server/org-unit.go:DeleteOrgUnit: whenallow_ou_deleteis enabled, setsdeletedto current unix timestamp via update (not hard-delete). Returns 200 OK without changing the timestamp if OU is already deleted (idempotent). ReturnsUnimplementedwhen feature is disabled (preserves existing behavior)UpdateOrgUnit: guard against updates on deleted OUs — returnscodes.FailedPrecondition/ 412 ifdeleted > 0GetOrgUnit/ListOrgUnits: wirestatusanddeletedfields into responses using the protoOrgUnitStatusenumExperimentalConfigintoOrgUnitServerfor feature-gated deletepkg/server/org-unit-user.go:AddOrgUnitUser: guard against adding users to a deleted OU — returnscodes.FailedPreconditionouTabletoOrgUnitUserServerfor OU lookup during the guard checkmain.go: passconf.GetExperimental()toNewOrgUnitServerDesign decisions:
Deletedfield (not stored separately) — single source of truthNewOrgUnitUserServersignature unchanged (OU table fetched via existingGetOrgUnitTable()singleton) to minimize call-site changesorg-unit-usersis a separate concern per the issueCloses #181