config: add ExperimentalConfig for OU delete#186
Conversation
Add ExperimentalConfig struct with: - allow_ou_delete (bool) — feature flag to enable OU deletion - hold_deleted_ou (int, seconds) — hold period before hard-delete Wire into BaseConfig and YAML parsing. Default behavior unchanged when config is absent (deletion remains unimplemented). Closes go-core-stack#180
|
Warning Review limit reached
More reviews will be available in 28 minutes and 7 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds experimental configuration block to enable and control org-unit soft-delete behavior (issue #180):
ExperimentalConfigstruct with two fields:allow_ou_delete(bool) — feature flag to enable OU deletion; when false (default), existing 501 Unimplemented behavior is preservedhold_deleted_ou(int, seconds) — duration to retain a soft-deleted OU before the reconciler hard-deletes itBaseConfigwithyaml:"experimental,omitempty"tag — YAML parsing picks it up automatically via the existingyaml.NewDecoderflowGetExperimental()getter — follows the same accessor pattern asGetResourceAliases()default.yamlupdated with commented-out example showing both fieldsDesign decisions
AllowOUDelete: false,HoldDeletedOU: 0— no nil checks neededWithDefaults()methodRateLimitsConfig, there are no non-zero defaults to apply; zero values mean "disabled"intfor hold duration (nottime.Duration)Default behavior
When
experimentalis absent from the config file,ExperimentalConfigzero-initializes to{AllowOUDelete: false, HoldDeletedOU: 0}— deletion remains unimplemented, no behavior change for existing deployments.Closes #180