Skip to content

docs: add RBAC architecture decision records#177

Open
Prabhjot-Sethi wants to merge 1 commit into
mainfrom
AUTHGW-0016
Open

docs: add RBAC architecture decision records#177
Prabhjot-Sethi wants to merge 1 commit into
mainfrom
AUTHGW-0016

Conversation

@Prabhjot-Sethi

@Prabhjot-Sethi Prabhjot-Sethi commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add docs/architecture/rbac-decisions.md documenting the key architectural decisions for the fine-grained RBAC implementation
  • Covers scope model design, constraint passing via headers, match criteria, performance architecture, and resource identifier extraction
  • Focuses on reasoning and alternatives considered ("why" not "what") to help future developers understand the design

Test plan

  • Review that decisions align with existing code behavior and planned FDP designs
  • Verify no implementation details or API specs leaked into the architecture doc
  • Confirm notes clearly distinguish current behavior from planned features

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added architectural decision documentation for role-based access control (RBAC) implementation, covering scope models, constraint management, performance strategies, and resource identifier handling.

Document the key architectural decisions for the fine-grained RBAC
implementation, covering scope model design, constraint passing via
headers, match criteria, performance architecture, and resource
identifier extraction. Focuses on reasoning and alternatives considered
to help future developers understand why the system works this way.

Refs: AUTHGW-0016
Signed-off-by: Prabhjot Singh Sethi <prabhjot.sethi@gmail.com>
@coderabbitai

coderabbitai Bot commented Feb 13, 2026

Copy link
Copy Markdown

Walkthrough

A new architectural decision record document has been added to capture design rationale for fine-grained RBAC implementation, including scope models, constraint handling via headers, match criteria, performance architecture with in-memory snapshots, and resource identifier extraction strategies.

Changes

Cohort / File(s) Summary
RBAC Architecture Documentation
docs/architecture/rbac-decisions.md
New decision document outlining scope design (unscoped/tenant/org-unit), constraint header passing, match criteria patterns, zero-database-call performance architecture with snapshots and change streams, and resource identifier extraction strategy.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A blueprint for roles so fine-grained and true,
Headers and scopes, constraints that are new,
Snapshots in memory, no databases to call,
RBAC decisions documented for all! 📋✨


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fef4be9838

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +21 to +22
| Tenant | `"tenant"` | Global within a tenant, accessible across all org-units | org-unit management, tenant settings |
| Org-unit | `"org-unit"` | Requires membership and role in a specific org-unit | workflow, model, dataset |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align documented scope tokens with gateway parser

This ADR lists scope config values as "tenant" and "org-unit", but the current request-path matcher only accepts a single scoped value of "ou" and rejects any other token with invalid scope (pkg/gateway/routes.go:118-121). If teams follow this table when registering routes, scoped endpoints will fail authorization at runtime, so the document should either use the currently supported token set or clearly label these values as a future schema change.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant