docs: add RBAC architecture decision records#177
Conversation
Document the key architectural decisions for the fine-grained RBAC implementation, covering scope model design, constraint passing via headers, match criteria, performance architecture, and resource identifier extraction. Focuses on reasoning and alternatives considered to help future developers understand why the system works this way. Refs: AUTHGW-0016 Signed-off-by: Prabhjot Singh Sethi <prabhjot.sethi@gmail.com>
WalkthroughA new architectural decision record document has been added to capture design rationale for fine-grained RBAC implementation, including scope models, constraint handling via headers, match criteria, performance architecture with in-memory snapshots, and resource identifier extraction strategies. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fef4be9838
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Tenant | `"tenant"` | Global within a tenant, accessible across all org-units | org-unit management, tenant settings | | ||
| | Org-unit | `"org-unit"` | Requires membership and role in a specific org-unit | workflow, model, dataset | |
There was a problem hiding this comment.
Align documented scope tokens with gateway parser
This ADR lists scope config values as "tenant" and "org-unit", but the current request-path matcher only accepts a single scoped value of "ou" and rejects any other token with invalid scope (pkg/gateway/routes.go:118-121). If teams follow this table when registering routes, scoped endpoints will fail authorization at runtime, so the document should either use the currently supported token set or clearly label these values as a future schema change.
Useful? React with 👍 / 👎.
Summary
docs/architecture/rbac-decisions.mddocumenting the key architectural decisions for the fine-grained RBAC implementationTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit