CI: Elevate warning to error if release version does not match.#738
Open
mmuetzel wants to merge 2 commits intognu-octave:mainfrom
Open
CI: Elevate warning to error if release version does not match.#738mmuetzel wants to merge 2 commits intognu-octave:mainfrom
mmuetzel wants to merge 2 commits intognu-octave:mainfrom
Conversation
Also, avoid contraction in message.
Member
Author
|
@pr0m1th3as: Thanks. I didn't look close enough what |
Member
I didn't look close enough too. Sorry for that, @mmuetzel. I just thought that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, avoid contraction in message.
Apparently, updating the
DESCRIPTIONfile for a package release is an easily missed step. At least, that was happening a couple of times in the last few weeks.Failing the CI in that case might raise awareness for that step.
I'll leave this open for at least a week or so and wait for feedback before merging.
If there is earlier agreement that this is something that we should do, we can also merge earlier.