Skip to content

CI: Elevate warning to error if release version does not match.#738

Open
mmuetzel wants to merge 2 commits intognu-octave:mainfrom
mmuetzel:ci2
Open

CI: Elevate warning to error if release version does not match.#738
mmuetzel wants to merge 2 commits intognu-octave:mainfrom
mmuetzel:ci2

Conversation

@mmuetzel
Copy link
Copy Markdown
Member

Also, avoid contraction in message.

Apparently, updating the DESCRIPTION file for a package release is an easily missed step. At least, that was happening a couple of times in the last few weeks.
Failing the CI in that case might raise awareness for that step.

I'll leave this open for at least a week or so and wait for feedback before merging.
If there is earlier agreement that this is something that we should do, we can also merge earlier.

Copy link
Copy Markdown
Member

@pr0m1th3as pr0m1th3as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this change.

@mmuetzel
Copy link
Copy Markdown
Member Author

@pr0m1th3as: Thanks.

I didn't look close enough what step_error actually does. I followed up with a change that actually marks the CI as "failed" if the versions do not match. (But still run the remaining steps.)

@pr0m1th3as
Copy link
Copy Markdown
Member

I didn't look close enough what step_error actually does.

I didn't look close enough too. Sorry for that, @mmuetzel. I just thought that step_error is the error handler function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants