Skip to content

Development environment setup for target autodiscovery#43

Open
denyost wants to merge 15 commits intomainfrom
dev/autodiscover
Open

Development environment setup for target autodiscovery#43
denyost wants to merge 15 commits intomainfrom
dev/autodiscover

Conversation

@denyost
Copy link
Copy Markdown
Collaborator

@denyost denyost commented Apr 8, 2026

  • Introduced the initial folder and file structure for the target autodiscovery feature.
  • Added temporary NetBox management support to the Makefile to facilitate target autodiscovery development (development-only; will be removed after implementation).
  • Included an Arista router in the Containerlab setup, along with the necessary gNMIc CRs for monitoring, to support target autodiscovery development (development-only; will be removed after implementation).

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 8, 2026

Deploying gnmic-operator with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc7f38e
Status: ✅  Deploy successful!
Preview URL: https://192cf74a.gnmic-operator2.pages.dev
Branch Preview URL: https://dev-autodiscover.gnmic-operator2.pages.dev

View logs

@denyost
Copy link
Copy Markdown
Collaborator Author

denyost commented Apr 9, 2026

@karimra The pull request fails because setup-envtest is pinned to @latest, which now requires Go ≥ 1.26.0, while the CI uses Go 1.25.8.
There is already a pull request to upgrade the Go version: #31.

@denyost denyost marked this pull request as draft April 10, 2026 09:09
@denyost
Copy link
Copy Markdown
Collaborator Author

denyost commented Apr 13, 2026

This PR now only prepares the development environment for target autodiscovery.

All TargetSource‑related changes and feature scaffolding were intentionally removed and have been moved to feature/target-loading-architecture.

The remaining changes are limited to development setup (Makefile helpers, Containerlab topology, and gNMIc CRs) and are development‑only.

@denyost denyost changed the title Initialize Target Autodiscovery Development Scaffold Development environment setup for target autodiscovery Apr 13, 2026
@denyost denyost marked this pull request as ready for review April 13, 2026 15:05
@denyost denyost requested a review from karimra April 13, 2026 15:05
@denyost
Copy link
Copy Markdown
Collaborator Author

denyost commented Apr 13, 2026

The CI failure is unrelated to our changes. The integration test times out while waiting for the cluster to become ready, which suggests that the pod startup takes longer than the configured timeout:

kubectl wait --for=condition=Ready cluster --all --timeout=180s
error: timed out waiting for the condition on clusters/c1
make: *** [Makefile:303: run-integration-tests] Error 1
Error: Process completed with exit code 2.

Comment thread lab/dev/3-nodes.clab.yaml.annotations.json Outdated
Comment thread lab/dev/netbox/readme.txt Outdated
Comment thread lab/dev/temp Outdated
@mcdillson
Copy link
Copy Markdown
Collaborator

@karimra I resolved the threads, should be ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants