Lazy load IllustrationManager - #25404
Merged
trasher merged 2 commits intoSep 7, 2026
Merged
Conversation
cedric-anne
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IllustrationManager requires files to be present at it instanciation; which assumes node deps have been installed.
For the CI of a plugin, I install GLPI and composer deps only, to run check headers command:
Of course I could just install npm deps plugin side, but that's not required, and that would take more time jusst for a lint job.
It seems also better this error not to happen in the constructor.
PR also fix a test that failed several times during my tests.