Fix passing arguments#7
Open
Neui wants to merge 1 commit into
Open
Conversation
`args` is already a tuple and `launch()` expects each argument to be a
CLI argument, so extract args so it parses correctly.
Fixes:
Traceback (most recent call last):
File "__startup__.py", line 133, in run
File "console.py", line 25, in run
File "Launcher.py", line 511, in <module>
File "Launcher.py", line 490, in main
File "Launcher.py", line 451, in run_component
File "/Archipelago/custom_worlds/slowrelease.apworld/slowrelease/__init__.py", line 8, in launch_client
File "/Archipelago/custom_worlds/slowrelease.apworld/slowrelease/Client.py", line 140, in launch
File "urllib/parse.py", line 394, in urlparse
File "urllib/parse.py", line 133, in _coerce_args
File "urllib/parse.py", line 117, in _decode_args
File "urllib/parse.py", line 117, in <genexpr>
AttributeError: 'tuple' object has no attribute 'decode'
Where `args == (('--nogui',),)` (when passed to `parsed_args`),
but this commit changes it to `args == ('--nogui',)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
argsis already a tuple andlaunch()expects each argument to be a CLI argument, so extract args so it parses correctly.What is this fixing or adding?
Fixes:
Where
args == (('--nogui',),)(when passed toparsed_args), but this commit changes it toargs == ('--nogui',).How was this tested?
Running
./ArchipelagoLauncher "Slow Release Client" -- --noguiIf this makes graphical changes, please attach screenshots.
Not applicable.