fix: read mint decimals from on-chain account instead of hardcoding 6#3
Open
gitteri wants to merge 1 commit into
Open
fix: read mint decimals from on-chain account instead of hardcoding 6#3gitteri wants to merge 1 commit into
gitteri wants to merge 1 commit into
Conversation
The RPC getTokenAccountBalance handler was returning incorrect UI amounts for tokens with non-6 decimals. Now reads the actual decimals byte from the mint account data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTokenAccountBalancehandler was hardcodingdecimals = 6for all tokens, producing incorrect UI amounts for tokens with non-6 decimals (e.g. SOL with 9, USDT with varying decimals across chains).decimalsbyte (offset 44) from the on-chain mint account data, falling back to an error if the mint account is missing or malformed.Changed files
core/src/rpc/get_token_account_balance_impl.rsTest plan
getTokenAccountBalancereturns correctuiAmountfor a 6-decimal token (e.g. USDC)uiAmountfor a 9-decimal token (e.g. SOL wrapped)Made with Cursor