Clarify README banner markdown instructions - #144
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies the README banner workflow and adds browser coverage.
Changes:
- Adds concrete banner saving and upload instructions.
- Centralizes generated Markdown creation.
- Tests popup text and raw GitHub URL.
Show a summary per file
| File | Description |
|---|---|
src/components/ReadmeBanner.tsx |
Generates Markdown and displays upload instructions. |
tests/health.spec.ts |
Tests the README banner popup content. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 631b4b4f-d5c8-43fa-a88d-517f12e2ae4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
banner.png.banner.pngmust be uploaded to the root of the user's profile repository and that the copied markdown points to/banner.pngonmain.Closes #21.
Validation
npm cinpm run checknpm run buildnpm run test