Use cluster endpoint at startup#90
Draft
piceri wants to merge 8 commits into
Draft
Conversation
Signed-off-by: Eric Pickard <piceri@github.com>
Signed-off-by: Eric Pickard <piceri@github.com>
Signed-off-by: Eric Pickard <piceri@github.com>
Signed-off-by: Eric Pickard <piceri@github.com>
Signed-off-by: Eric Pickard <piceri@github.com>
Signed-off-by: Eric Pickard <piceri@github.com>
Signed-off-by: Eric Pickard <piceri@github.com>
Signed-off-by: Eric Pickard <piceri@github.com>
ajbeattie
reviewed
Jun 1, 2026
Contributor
ajbeattie
left a comment
ajbeattie
left a comment
There was a problem hiding this comment.
Nice 💯, looking great on initial pass. Still working through some of the changes but wanted to go ahead and raise the Job/CronJob suggestion ⬇️
| // informerSyncTimeout is the maximum time allowed for all informers to sync | ||
| // and prevents sync from hanging indefinitely. | ||
| informerSyncTimeout time.Duration | ||
| syncing atomic.Bool |
Contributor
There was a problem hiding this comment.
Prob worth adding a comment here and a few in New/Run below explaining what syncing means/does.
| continue | ||
| } | ||
|
|
||
| if pod.Status.Phase != corev1.PodRunning || !workload.HasSupportedOwner(pod) { |
Contributor
There was a problem hiding this comment.
I think here we'll also need to accept terminal-state jobs like in the AddFunc, i.e. (workload.IsTerminalPhase(pod) && workload.GetJobOwnerName(pod) != "") so that we don't miss any jobs that run and complete while the sync is happening aren't dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows deployment tracker to use the cluster endpoint at startup to send the current state of the cluster. This will reduce the load cause at startup when deployment tracker sends the state of the cluster one container at a time.
Change details: