Skip to content

Try upgrading github/codeql dependency to 2.22.4 without merging next for performance testing - #1187

Open
MichaelRFairhurst wants to merge 2 commits into
mainfrom
michaelrfairhurst/try-only-upgrade-to-2.22.4
Open

Try upgrading github/codeql dependency to 2.22.4 without merging next for performance testing#1187
MichaelRFairhurst wants to merge 2 commits into
mainfrom
michaelrfairhurst/try-only-upgrade-to-2.22.4

Conversation

@MichaelRFairhurst

Copy link
Copy Markdown
Collaborator

Description

please enter the description of your change here

Change request type

  • Release or process automation (GitHub workflows, internal scripts)
  • Internal documentation
  • External documentation
  • Query files (.ql, .qll, .qls or unit tests)
  • External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

  • No rules added
  • Queries have been added for the following rules:
    • rule number here
  • Queries have been modified for the following rules:
    • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

  • The structure or layout of the release artifacts.
  • The evaluation performance (memory, execution time) of an existing query.
  • The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

  • Yes
  • No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

  • Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

  • Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Reviewer

  • Have all the relevant rule package description files been checked in?
  • Have you verified that the metadata properties of each new query is set appropriately?
  • Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
  • Are the alert messages properly formatted and consistent with the style guide?
  • Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
    As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
  • Does the query have an appropriate level of in-query comments/documentation?
  • Have you considered/identified possible edge cases?
  • Does the query not reinvent features in the standard library?
  • Can the query be simplified further (not golfed!)

Copilot AI balanced review requested due to automatic review settings August 26, 2026 20:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the repository’s supported CodeQL toolchain to CLI 2.22.4 for performance testing.

Changes:

  • Updates CodeQL CLI, standard library, and bundle references.
  • Upgrades codeql/cpp-all to 5.4.1 and refreshes transitive locks.
  • A required release change note is missing.
Show a summary per file
File Description
supported_codeql_configs.json Targets CodeQL 2.22.4.
scripts/generate_modules/queries/qlpack.yml Upgrades cpp-all.
scripts/generate_modules/queries/codeql-pack.lock.yml Refreshes locked dependencies.
cpp/report/src/qlpack.yml Upgrades cpp-all.
cpp/report/src/codeql-pack.lock.yml Refreshes report dependencies.
cpp/misra/test/codeql-pack.lock.yml Refreshes MISRA C++ test dependencies.
cpp/misra/src/qlpack.yml Upgrades cpp-all.
cpp/misra/src/codeql-pack.lock.yml Refreshes MISRA C++ dependencies.
cpp/common/test/codeql-pack.lock.yml Refreshes common C++ test dependencies.
cpp/common/src/qlpack.yml Upgrades cpp-all.
cpp/common/src/codeql-pack.lock.yml Refreshes common C++ dependencies.
cpp/cert/test/codeql-pack.lock.yml Refreshes CERT C++ test dependencies.
cpp/cert/src/qlpack.yml Upgrades cpp-all.
cpp/cert/src/codeql-pack.lock.yml Refreshes CERT C++ dependencies.
cpp/autosar/test/codeql-pack.lock.yml Refreshes AUTOSAR test dependencies.
cpp/autosar/src/qlpack.yml Upgrades cpp-all.
cpp/autosar/src/codeql-pack.lock.yml Refreshes AUTOSAR dependencies.
c/misra/test/codeql-pack.lock.yml Refreshes MISRA C test dependencies.
c/misra/src/qlpack.yml Upgrades cpp-all.
c/misra/src/codeql-pack.lock.yml Refreshes MISRA C dependencies.
c/common/test/codeql-pack.lock.yml Refreshes common C test dependencies.
c/common/src/qlpack.yml Upgrades cpp-all.
c/common/src/codeql-pack.lock.yml Refreshes common C dependencies.
c/cert/test/codeql-pack.lock.yml Refreshes CERT C test dependencies.
c/cert/src/qlpack.yml Upgrades cpp-all.
c/cert/src/codeql-pack.lock.yml Refreshes CERT C dependencies.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 26/26 changed files
  • Comments generated: 1
  • Review effort level: Balanced

"codeql_cli": "2.21.4",
"codeql_standard_library": "codeql-cli/v2.21.4",
"codeql_cli_bundle": "codeql-bundle-v2.21.4"
"codeql_cli": "2.22.4",
@MichaelRFairhurst

Copy link
Copy Markdown
Collaborator Author

/test-performance

@github-actions

Copy link
Copy Markdown

🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute.

💡 If you do not hear back from me please check my status! I will report even if I fail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants