(scratch) test: track RFC 4787, and state its requirements as executable contracts - #1741
(scratch) test: track RFC 4787, and state its requirements as executable contracts#1741daniel-noland wants to merge 37 commits into
Check failed
There are 18 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | cd391d0 | docs(testing): Record what mutation testing is for... | Valid sign-off found |
| 🟢 | 8a5647e | fix(net): Validate the RFC 4884 original datagram ... | Valid sign-off found |
| 🟢 | 8b92d3a | build(duvet): Track RFC 4884 compliance, and vendo... | Valid sign-off found |
| 🟢 | a427e0c | build(duvet): Track RFC 5382, and record where mas... | Valid sign-off found |
| 🔴 | ab5d086 | docs(testing): Record what duvet can and cannot pa... | Sign-off not found |
| 🔴 | 16bd80c | build(duvet): Track RFC 4787, and record where mas... | Sign-off not found |
| 🔴 | 8287e76 | test(masquerade): State RFC 4787 endpoint independ... | Sign-off not found |
| 🔴 | da33f3a | test(masquerade): Assert RFC 4787 outbound refresh... | Sign-off not found |
| 🔴 | 2653652 | test(masquerade): Classify masquerade's filtering,... | Sign-off not found |
| 🔴 | 74f81a4 | docs(testing): Record what the RFC errata say, and... | Sign-off not found |
| 🔴 | 29a7861 | test(masquerade): State RFC 4787 REQ-12 as an exec... | Sign-off not found |
| 🔴 | e7d0520 | test(masquerade): Make a stale citation a build fa... | Sign-off not found |
| 🔴 | faf1071 | docs(forwarding): Record RFC 4787 REQ-13, and why ... | Sign-off not found |
| 🔴 | 631488c | fix(duvet): Regenerate the snapshot the REQ-12 and... | Sign-off not found |
| 🔴 | 13e981b | docs(testing): Record what the interlock found, an... | Sign-off not found |
| 🔴 | bbf5690 | docs(testing): Record where a citation goes when t... | Sign-off not found |
| 🔴 | d75aaa7 | test(net): Take the RFC 4884 minimum from both sid... | Sign-off not found |
| 🔴 | 56ced01 | test(nat): Cite port overloading on the code that ... | Sign-off not found |
| 🔴 | 1799836 | test(nat): Cite the exhaustion walk alongside the ... | Sign-off not found |
| 🔴 | 88b7b64 | docs(testing): Record the three tiers, and the two... | Sign-off not found |
| 🔴 | fea7d1d | docs(nat): Drop the process narration from the cit... | Sign-off not found |
| 🔴 | 762b44a | fix(net): Backtick a doc identifier | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~22 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin pr/daniel-noland/spec-compliance