perf(ci): make the nix dependency build reusable across revisions - #1722
perf(ci): make the nix dependency build reusable across revisions#1722daniel-noland wants to merge 23 commits into
Check failed
There are 16 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | a213082 | ci: reserve Cachix for reusable build inputs | Valid sign-off found |
| 🔴 | e0397ed | ci: accept a prewarmed nix on the lab runners | Sign-off not found |
| 🔴 | 26c6670 | ci: keep workspace outputs substitutable | Sign-off not found |
| 🔴 | bde28cd | fix(nix): keep results out of the build source |
Sign-off not found |
| 🔴 | 976d062 | perf(nix): share one dependency build per flag-set | Sign-off not found |
| 🔴 | 6ac0498 | perf(nix): remap sources to a fixed prefix | Sign-off not found |
| 🔴 | 1719c82 | ci: widen matrix parallelism for deep runs | Sign-off not found |
| 🔴 | d76a918 | ci: honour ci:-vlab again | Sign-off not found |
| 🔴 | 10f021d | ci: retry container pushes | Sign-off not found |
| 🔴 | a9eb51e | perf(nix): keep the git version out of the depende... | Sign-off not found |
| 🔴 | 958cd68 | ci: check that the dependency build stays reusable | Sign-off not found |
| 🔴 | 0a58ac0 | build(nix): optional cargo build timing report | Sign-off not found |
| 🔴 | 2ee24b7 | ci: build clippy, doctests, and docs through nix | Sign-off not found |
| 🔴 | 0afb548 | perf(nix): lint the workspace in one derivation | Sign-off not found |
| 🔴 | 9aa9b77 | ci: give nix the whole core budget, and split it f... | Sign-off not found |
| 🔴 | 6367dd8 | ci: cut the coverage test floor and stop checking ... | Sign-off not found |
| 🔴 | c495efc | docs(ci): document the ci:-vlab label | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~17 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin pr/daniel-noland/ci-nix-cache