Skip to content

release: harden v17 publish package#86

Merged
flyingrobots merged 5 commits into
mainfrom
release/v17.0.0-publish-hardening
May 18, 2026
Merged

release: harden v17 publish package#86
flyingrobots merged 5 commits into
mainfrom
release/v17.0.0-publish-hardening

Conversation

@flyingrobots
Copy link
Copy Markdown
Member

@flyingrobots flyingrobots commented May 18, 2026

Summary

  • ratchet v17 coverage threshold to the passing 91.87% line coverage value
  • make native roaring an optional dependency so the package can install on runtimes where the native binding is unavailable
  • keep roaring-wasm as the required runtime fallback used by the existing loader chain

Why

Release preflight exposed that roaring@2.7.0 cannot build under Node 26. The runtime loader already falls back to roaring-wasm, but npm never reached that fallback while native roaring was a hard dependency. Marking it optional lets npm continue and lets the loader use the WASM implementation.

Validation

  • bash scripts/smoke-packed-artifact.sh under Node 26
  • npx vitest run test/unit/domain/utils/roaring.test.ts
  • npm run typecheck:surface
  • full npm run release:preflight under Node 22 via Node 22 on PATH
  • pre-push IRONCLAD M9, including npm run test:local

Summary by CodeRabbit

  • Chores
    • Updated package dependencies configuration to optimize installation behavior
    • Adjusted code quality testing thresholds

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@flyingrobots has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 33 minutes and 22 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 14db7959-edbc-4b1c-9357-35ca840cc722

📥 Commits

Reviewing files that changed from the base of the PR and between 4acf56c and 2096fbe.

📒 Files selected for processing (8)
  • .github/workflows/links.yml
  • docs/method/backlog/bad-code/README.md
  • docs/method/backlog/bad-code/RELEASE_TRIAGE.md
  • docs/method/backlog/bad-code/SPEC_required-link-check-path-filter.md
  • test/unit/domain/capabilities/MaterializedSnapshot.test.ts
  • test/unit/domain/errors/StateSessionError.test.ts
  • test/unit/domain/services/snapshot/SnapshotValues.test.ts
  • test/unit/infrastructure/adapters/RoaringLoaderAdapter.test.ts
📝 Walkthrough

Walkthrough

This PR makes two independent configuration adjustments: moving roaring from required to optional dependencies in package.json, and incrementally raising the test coverage threshold for lines from 91.74% to 91.87% in the Vitest configuration.

Changes

Dependency and Configuration Updates

Layer / File(s) Summary
Optional roaring dependency
package.json
roaring is moved from dependencies to optionalDependencies, while roaring-wasm, string-width, wrap-ansi, zod, and other packages remain in dependencies.
Test coverage threshold update
vitest.config.ts
Vitest configuration increases the test.coverage.thresholds.lines value from 91.74 to 91.87.

🎯 1 (Trivial) | ⏱️ ~3 minutes

A rabbit hops through configs with care,
Optional roaring floats through the air,
Coverage climbs high—91.87 shines so bright,
These small tweaks make the testing just right! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'release: harden v17 publish package' is directly related to the main changes: tightening coverage thresholds and adjusting dependency configurations for the v17 release.
Description check ✅ Passed The description provides a comprehensive summary, detailed rationale, and validation steps. The ADR checks section from the template is not applicable to this release-focused PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/v17.0.0-publish-hardening

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Release Preflight

  • package version: 17.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v17.0.0, release workflow will publish.

@github-actions
Copy link
Copy Markdown

Release Preflight

  • package version: 17.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v17.0.0, release workflow will publish.

@github-actions
Copy link
Copy Markdown

Release Preflight

  • package version: 17.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v17.0.0, release workflow will publish.

@flyingrobots flyingrobots merged commit f98419d into main May 18, 2026
9 checks passed
@flyingrobots flyingrobots deleted the release/v17.0.0-publish-hardening branch May 18, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant