msauth: isolate macOS user token cache - #2413
Open
thomasaarholt wants to merge 1 commit into
Open
Conversation
Use a GCM-owned Keychain item on macOS so other Microsoft developer tools cannot replace the shared cache item and discard GCM's access control entry. Preserve shared cache behavior on Windows and Linux. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
On macOS, GCM shares the
Microsoft.Developer.IdentityServiceMSAL Keychain item with other Microsoft developer tools. When another tool recreates this item, its access-control list can lose GCM's entry, causing repeated Keychain password prompts even after selecting Always Allow.The solution
Use a GCM-owned Keychain item and cache file for the macOS user-token cache. This prevents other applications from changing GCM's Keychain permissions while retaining persistent authentication between GCM processes.
Windows and Linux continue using the shared Microsoft developer cache. macOS users may need to authenticate once after upgrading to populate the new cache.
Fixes #2079.
Testing
dotnet test src/shared/Core.Tests/Core.Tests.csproj --no-restore --nologodotnet build -c MacDebug --no-restore --nologo