entra: ensure we only configure broker when app supports it - #2381
Merged
Conversation
Only correctly configure the broker when the application config states that it is configured correctly for the broker. Without this check it is possible that we configure a public client application that has the broker enabled, but the application config does NOT have the correct redirect URI configured. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
mjcheetham
added
auth:entra
mjcheetham
marked this pull request as ready for review
July 14, 2026 14:40
mjcheetham
enabled auto-merge
July 14, 2026 14:50
dscho
approved these changes
Jul 14, 2026
dscho
left a comment
dscho
left a comment
Contributor
There was a problem hiding this comment.
With git show -w, this commit looks obviously correct to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only correctly configure the broker when the application config states that it is configured correctly for the broker.
Without this check it is possible that we configure a public client application that has the broker enabled, but the application config does NOT have the correct redirect URI configured.
Easiest to review without whitespace changes highlighted.