GitHub Support

[mrauer]

No description provided.

[tlvenn]

It might be a good idea to update the doc and other parts of the code to add Github support in addition to Google and Azure @mrauer.

[tlvenn]

Hi @mrauer,

Did you actually test that PR ?
On my side i do end up with an error:

Failed to write k8s config: Failed to parse token: square/go-jose: compact JWS format must have three parts

And now that I have looked into it, it seems to me that Github does not actually implement OIDC spec so it seems impossible to use it as a provider...

[dkerwin]

Thank you for this PR. I'll have a look but I agree with @tlvenn that it may not work

[dkerwin]

Hey @mrauer,

fyi: once #30 is merged it becomes very easy to add new providers to dexter

[dkerwin]

Not that #30 is merged it is very easy to extend dexter with new providers. Would love to see you implement the first github provider ;-)

[tlvenn]

It's great that the PR was merged but keep in mind that until Github decides to support OIDC, it's not really possible to support it.

[dkerwin]

You are right. Given that it's not possible with Github without something like dex in the middle I'll close this PR