Post-Beta maintenance: startup reconciliation, datetime precision, trend bucketing (DEF-017/027/028) - #7
Merged
Merged
Conversation
…ndary (DEF-027) Two related fixes in the transaction query/response path: 1. Responses now serialize dates as RFC3339 strings, so list/create/update carry full second precision instead of date-only values that rendered as local 08:00. 2. A plain calendar end date is now an exclusive next-midnight boundary (date < 'YYYY-MM-DD 00:00:00') via endDateFilter, so rows created on the final day of a filter window are no longer dropped; explicit timestamp bounds keep inclusive <= semantics. Unit tests cover serialization round-trips and both filter forms.
…F-028) calculateBalanceTrend grouped transaction rows by UTC day while the trend walk uses server-local (+08) days, so editing a transaction's date never re-converged the trend. Bucket by the walk's zone and add a regression test emulating a Postgres-scanned (UTC-location) row.
gtime.NewFromStr parses naive wall-clock strings in time.Local, so the DEF-027 round-trip test depended on the runner timezone (fails in UTC CI). Pin time.Local to the +08 production zone for the duration of the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-Beta maintenance round (release-beta-060903).
GAAP_STARTUP_RECONCILIATION=block|warn|off).endDateFilter).dlv@v1.23.1(dlv 1.27.x requires Go >= 1.25).Verification:
go build/testgreen; local UAT security-gate 7/7; trend lifecycle converges on first read after each create/edit/delete.