Conversation
The container never started. pydantic-settings treats list-typed fields as complex and JSON-decodes the environment value inside the settings source, which runs before field validators -- so CORS_ORIGINS=https://embeddings. mannymcgrail.com failed json.loads and raised SettingsError at import, before _split_csv ever saw it. ALLOWED_MODELS would have failed identically on the next line. Development never hit this because both fields fall back to default_factory when unset, and they are only set in deployment. Marking both fields NoDecode hands the raw string to the validator. That on its own would have silently dropped support for JSON array values, which is what pydantic-settings accepted before, so the validator now takes either form. Adds test_config.py covering both, plus the exact environment docker-compose.yml sets. Raises the pydantic-settings floor to 2.3, which introduced NoDecode. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Fix/settings env parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.