Show composer in Album View - #272
Open
timrosenberg wants to merge 7 commits into
Open
Conversation
Composer renders on its own line below the artist line, only when showComposer is true and track.displayComposer is set. Rows without a composer, or with showComposer false, are unchanged.
TrackRow: composer subtitle line behind showComposer
Turns on the composer subtitle line (TrackRow, issue #2) for Album View only, by opting its TrackRow render site into showComposer. Queue, playlist, and search rows that reuse TrackRow are untouched.
The render test already proves showComposer reaches TrackRow for the tracks that carry a composer, and TrackRow's own suite covers the false/absent cases. Two near-identical screen mock harnesses for one prop isn't worth maintaining.
Album View: pass showComposer from album-detail
…d trip Traced both offline read paths for a production gap: the normalized songs table's mapper and the legacy cached_songs promoted-column list already carry displayComposer both directions. This guards the path album-detail.tsx actually reads on a cache hit (getAlbumDetail), which had no direct coverage.
Composer: offline/cached parity test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the composer to Album View. Subsonic/OpenSubsonic servers already return
displayComposerper song; the app fetched and cached it but never displayed it anywhere.Changes
TrackRowgains an opt-inshowComposerprop — when set and the track has adisplayComposer, a third line renders below the artist line (icon + composer name, truncated to one line). Hidden entirely when there's no composer.Textcarries an explicit accessibility label ("Composer: …") so VoiceOver never confuses it with the artist.Testing
npx tsc --noEmitcleannpx jest --no-coveragegreen — 536 suites, 9420 testsnode scripts/validate-intl.js/validate-translations.jscleannpx madge --circular— no circular depsTrackRow.test.tsx(present/absent/multi-composer/truncation/a11y label),album-detail.composer-render.test.tsx(end-to-end on a mixed-composer album),details.test.ts(composer survives the DB round trip on the offline/cached read path)