Add multiple artists support - #263
Open
Jimmyscene wants to merge 3 commits into
Open
Conversation
Support OpenSubsonic multi-artist (artists[] array) across three surfaces: - Now-playing screen (phone + tablet): render each artist as an inline tappable chip with middot separators; single-artist fallback wraps in Pressable; offline renders plain text - Album detail hero: same multi-artist handling on the artist name - More Options Sheet: multi-artist picker with artist selection sub-view Also adds accessibilityRole/accessibilityLabel to all artist Pressables and hides the Top Songs/All Songs toggle when topSongs is empty.
The UI is a bit confusing here when no songs are listed, there's just a pill that doesn't do anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed songs and albums with multiple artists didn't surface the secondary artists anywhere, so I added support for that, plus a couple of small fixes I came across on the artist detail page. I tried to stay consistent with the existing patterns in the repo, but happy to adjust anything if you'd prefer it done differently.
Changes:
Tappable artist links — when a song or album has multiple artists, they now appear as inline, tappable links (separated by ·) each jumping straight to that artist's page
"Go to Artist" picker — if a song/album has more than one artist, the more-options sheet now shows an in-sheet "Select Artist" picker with a back button instead of silently picking the first artist. Single-artist cases behave exactly as before.
Artist detail cleanup — dedupes the similar-artists list (Navidrome can return the same artist more than once, which left gaps in the list), and hides the "Top songs / All songs" toggle when an artist has no top songs to switch between.
Testing
npx tsc --noEmitpassesnpx jest --no-coveragepassesRelated Issues
Closes #