refactor: replace embd_normalize integer parameter with enum#24173
Open
SaurabhCodes-16 wants to merge 1 commit into
Open
refactor: replace embd_normalize integer parameter with enum#24173SaurabhCodes-16 wants to merge 1 commit into
SaurabhCodes-16 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the embedding normalization parameter from a plain
intto a strongly typed enumcommon_embd_norm, addressing the inline TODO comment incommon/common.h.Specifically:
enum common_embd_normrepresenting the normalization types (-1=none, 0=max absolute, 1=taxicab, 2=euclidean).common_embd_normalizesignature and all parsing, server, and example client usages.COMMON_EMBD_NORM_TAXICAB) avoiding unnecessarystd::powcalls.Requirements