opencl: improve get_rows, cpy, concat and q6_k flat gemv#24160
Open
lhez wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Current implementations of get_rows, cpy and concat perform poorly with Qwen3.5. In particular, they all assign one workgroup to one row. When there is only one large row or a lot of very small rows, GPU becomes underutilized. This is improved in this PR.
This PR also tweaks how threads are mapped to data to improve coalescing in Q6_K flat gemv kernel. This helps with models with Q6_K output weights.
Additional information
Details
X2-90 (before, after)
Qwen3.5 9B
build: 94a220c (9496)
build: 0fb3d35 (9500)
Qwen3.5 4B
build: 94a220c (9496)
build: 0fb3d35 (9500)
Qwen3 8B
build: 94a220c (9496)
build: 0fb3d35 (9500)
Qwen3 4B
build: 94a220c (9496)
build: 0fb3d35 (9500)
llama3.2 3B
build: 94a220c (9496)
build: 0fb3d35 (9500)
Requirements