Skip to content

ui: fix mobile chat form overflow and bust stale bundle cache#24158

Open
ServeurpersoCom wants to merge 1 commit into
ggml-org:masterfrom
ServeurpersoCom:ui/fix-mobile-height
Open

ui: fix mobile chat form overflow and bust stale bundle cache#24158
ServeurpersoCom wants to merge 1 commit into
ggml-org:masterfrom
ServeurpersoCom:ui/fix-mobile-height

Conversation

@ServeurpersoCom
Copy link
Copy Markdown
Contributor

Overview

This PR fixes a mobile nitpick and a developer pain point in one go

Additional information

Chat form overflowing below the visual viewport on mobile browsers: the root container moves from h-screen to h-dvh so the layout tracks the actual visible height, with identical behavior in standalone PWA and on desktop.

Stale bundle cache busting: the build plugin appends the Vite hash as a query string to bundle.js and bundle.css in index.html, so a simple reload always fetches the latest build. Essential when iterating on UI fixes and verifying them on a real device.

Before

Bug

After

BugFix

Requirements

On mobile browsers the root container uses h-screen (100vh), which measures
the large viewport with the browser UI retracted. With the Chrome toolbar
visible the chat form sinks below the visual viewport by exactly the toolbar
height. Switch to h-dvh so the layout always tracks the visible height. In
standalone PWA and on desktop dvh equals vh, so nothing changes there.

Checking such CSS details on a real phone is painful: bundle.js and
bundle.css keep fixed names, so a normal reload serves stale cached bundles.
The build plugin now appends the Vite hash as a query string (bundle.js?<hash>),
so every new build is fetched fresh after a simple reload.
@ServeurpersoCom
Copy link
Copy Markdown
Contributor Author

cc @allozaur Can you test it with your llama.app packaging and your smartphone? This should not change anything for you while repairing Android.

@ServeurpersoCom ServeurpersoCom requested a review from allozaur June 5, 2026 05:48
@kashif
Copy link
Copy Markdown
Contributor

kashif commented Jun 5, 2026

works nicely on ios too

Image from iOS

@ServeurpersoCom
Copy link
Copy Markdown
Contributor Author

Thanks for the iPhone test!

@allozaur
Copy link
Copy Markdown
Contributor

allozaur commented Jun 5, 2026

Just a side note that we will have mobile UI improvements implemented in nearest future, but let's merge the fix to address this particular issue.

@allozaur allozaur requested a review from ggerganov June 5, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants