HIP: add gfx1152 and gfx1153 to RDNA3.5#24129
Open
harkgill-amd wants to merge 1 commit into
Open
Conversation
Contributor
|
It seems to work; I have a gfx1152 system. It's still a little slower than Vulkan of course, but it isn't a bunch of stuttering nonsense either. |
|
Not related to this PR but why is this labeled Nvidia GPU by the bot? I have seen this obviously wrong labeling several times now. |
On my laptop HP Omnibook with Ryzen 7 AI 350, I have (on CachyOS) with ROCm 17 TPS, with Vulkan 27 TPS. Model Gemma 4 e4b with 32k |
|
Works for me on System76 Pangolin Pro Gemma4Bonsai-8B |
JohannesGaessler
approved these changes
Jun 5, 2026
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add gfx1152 and gfx1153 definitions to RDNA3.5 macro in
ggml/src/ggml-cuda/vendors/hip.h.Additional information
Resolves ROCm/TheRock#5579 where users report corrupted output with TheRock nightlies + llama.cpp build from source. Patching this change in resolves the issue.
Requirements