Add ctx-per-slot argument for unified KV cache#24124
Open
bartowski1182 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds two new arguments for llama-server context provisioning
ctx-per-slot
First argument,
--ctx-per-slotThis specifies how much context each slot is limited to in the
kvumode, so for example if a user wants to have N slots with each having 4096 context, they can specify--ctx-per-slot 4096, it will provision 16384 total context:If specified with
-c, you will then limit the total context:If you set
-cto a value lower than--ctx-per-slot, it will warn and cap to-c's value:ctx-pool-slots
Also adds another new flag,
--ctx-pool-slots, which specifies how many slots worth of context should be allocated, this is similar to setting-cto an explicit value but doesn't require the user to manually do the math ahead of time:If you specify more pool slots than
np, it will warn and clamp tonp:Since this is purely a helper argument, I wouldn't mind dropping it from the PR, I think it would be nice to have but I've been told the server arguments are already getting a bit bloated...
Requirements