Add Clang coverage pass integrated with test build flow#2
Draft
ggeier wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
COLDTRACE_ENABLE_COVERAGEto enable Clang coverage instrumentation and enforce Clang when enabled, and disable IPO while coverage is active.-fprofile-instr-generateand-fcoverage-mapping, and wirellvm-profdata/llvm-covusage to generate reports.COLDTRACE_TEST_TARGETSintest/CMakeLists.txtand use that list to build coverage object lists for reporting.coveragecustom target that runs the test suite viactestwithLLVM_PROFILE_FILE, merges profiles viallvm-profdata, emits a summary viallvm-cov report, and exports LCOV tocoverage/coverage.lcov, and document usage inREADME.md.Testing
cmake -S . -B build-coverage -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCOLDTRACE_ENABLE_COVERAGE=ON, which configured successfully.coveragetarget withcmake --build build-coverage --target coverage -j4, which failed during linking in this environment due to Swift/Clang TSAN runtime / libdispatch linker incompatibilities unrelated to the coverage wiring; the failure prevented completing runtime test execution and profile merging.Codex Task